Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete has valid value 73f2c2 #1583

Merged
merged 10 commits into from
Jun 7, 2021
Merged

Conversation

ajanec01
Copy link
Collaborator

Applying suggestions from the previous CG call.

Closes issue(s):

No need for final call.

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Final Call period. In case of disagreement, the longer period wins.

@ajanec01 ajanec01 self-assigned this Apr 24, 2021
@ajanec01 ajanec01 changed the title applying changes in response to Wilco's and Jym77's suggestions Autocomplete has valid value 73f2c2 Apr 24, 2021
Copy link
Member

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple editorial suggestions. Rest looks great.

_rules/autocomplete-valid-value-73f2c2.md Outdated Show resolved Hide resolved
_rules/autocomplete-valid-value-73f2c2.md Outdated Show resolved Hide resolved
_rules/autocomplete-valid-value-73f2c2.md Outdated Show resolved Hide resolved
_rules/autocomplete-valid-value-73f2c2.md Outdated Show resolved Hide resolved
@ajanec01 ajanec01 requested a review from WilcoFiers April 27, 2021 12:32
@ajanec01 ajanec01 dismissed WilcoFiers’s stale review April 27, 2021 12:33

All suggestions commited.

Jym77
Jym77 previously requested changes May 6, 2021
_rules/autocomplete-valid-value-73f2c2.md Outdated Show resolved Hide resolved
_rules/autocomplete-valid-value-73f2c2.md Outdated Show resolved Hide resolved
@ajanec01 ajanec01 requested a review from Jym77 May 8, 2021 22:26
@ajanec01 ajanec01 dismissed Jym77’s stale review May 8, 2021 22:26

All done!

Copy link
Member

@carlosapaduarte carlosapaduarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor edits

_rules/autocomplete-valid-value-73f2c2.md Outdated Show resolved Hide resolved
@ajanec01 ajanec01 requested a review from carlosapaduarte June 2, 2021 22:03
@ajanec01 ajanec01 dismissed carlosapaduarte’s stale review June 2, 2021 22:04

Committed, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

autocomplete="off" fails "autocomplete attribute has valid value" (73f2c2)
4 participants