-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autocomplete has valid value 73f2c2 #1583
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajanec01
requested review from
Jym77,
WilcoFiers,
jeeyyy,
annethyme,
carlosapaduarte,
daniel-montalvo and
EmmaJP
and removed request for
Jym77 and
WilcoFiers
April 24, 2021 18:59
ajanec01
changed the title
applying changes in response to Wilco's and Jym77's suggestions
Autocomplete has valid value 73f2c2
Apr 24, 2021
WilcoFiers
previously requested changes
Apr 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple editorial suggestions. Rest looks great.
Co-authored-by: Wilco Fiers <[email protected]>
Co-authored-by: Wilco Fiers <[email protected]>
Co-authored-by: Wilco Fiers <[email protected]>
Co-authored-by: Wilco Fiers <[email protected]>
WilcoFiers
approved these changes
May 5, 2021
Jym77
previously requested changes
May 6, 2021
Co-authored-by: Jean-Yves Moyen <[email protected]>
Co-authored-by: Jean-Yves Moyen <[email protected]>
Jym77
approved these changes
May 20, 2021
carlosapaduarte
previously requested changes
Jun 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor edits
Co-authored-by: Carlos Duarte <[email protected]>
carlosapaduarte
approved these changes
Jun 7, 2021
This was referenced Aug 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applying suggestions from the previous CG call.
autocomplete="off"
is not a failure by changing the applicabilitytype
? #1562 (Firefox, Safari, and Chrome do not care iftype
value is appropriate)Closes issue(s):
No need for final call.
How to Review And Approve